[alsa-devel] [PATCH] ASoC: soc-core: Fix sparse warning in be32_to_cpup() call

Mark Brown broonie at kernel.org
Thu Sep 17 11:22:29 CEST 2015


On Thu, Sep 17, 2015 at 11:02:57AM +0300, Jyri Sarha wrote:

>  	val /= sizeof(u32);
>  	for (i = 0; i < val; i++)
> -		if (be32_to_cpup(&of_slot_mask[i]))
> +		if (be32_to_cpup((__be32 *)&of_slot_mask[i]))
>  			*mask |= (1 << i);
>  

There was no changelog and this is setting off alarm bells since the
cast just smashes warnings - are you sure we're not missing some other
annotations and that a cast is the best thing here?
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 473 bytes
Desc: Digital signature
URL: <http://mailman.alsa-project.org/pipermail/alsa-devel/attachments/20150917/52b603df/attachment-0001.sig>


More information about the Alsa-devel mailing list