[alsa-devel] Missing return check of of_property_read_*()

Mark Brown broonie at kernel.org
Wed Sep 9 16:51:58 CEST 2015


On Wed, Sep 09, 2015 at 04:40:36PM +0200, Takashi Iwai wrote:

> I hoped that I wouldn't need to write this kind of post, but since
> nothing happened so far, so here we go:

Could you be more specific about nothing happening here...

> The following compile warnings are present for quite some time.  They
> are due to the lack of return check from of_property_read*().

> sound/soc/codecs/cs35l32.c: In function ‘cs35l32_i2c_probe’:
> sound/soc/codecs/cs35l32.c:278:2: warning: ‘val’ may be used uninitialized in this function [-Wmaybe-uninitialized]
>   switch (val) {
>   ^
> sound/soc/codecs/cs35l32.c:272:15: note: ‘val’ was declared here
>   unsigned int val;
>                ^

How are you generating these - what compiler and config?  None of the
build bots are reporting any of the warnings you have here.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 473 bytes
Desc: Digital signature
URL: <http://mailman.alsa-project.org/pipermail/alsa-devel/attachments/20150909/1682a827/attachment.sig>


More information about the Alsa-devel mailing list