[alsa-devel] [PATCH] FSL_SSI: fix fsl_ssi interrupt reporting so that interrupts are only reported when they have been enabled.

Fabio Estevam festevam at gmail.com
Wed Oct 28 21:25:59 CET 2015


On Wed, Oct 28, 2015 at 6:18 PM, Caleb Crome <caleb at crome.org> wrote:
> On Wed, Oct 28, 2015 at 1:08 PM, Fabio Estevam <festevam at gmail.com> wrote:
>> Hi Caleb,
>>
>> On Wed, Oct 28, 2015 at 5:53 PM, Caleb Crome <caleb at crome.org> wrote:
>>
>>> +// call fsl_ssi_dbg_update_sier_enbled every time sier is
>>> +// updated.  it tracks which interrupts have ever been enabled.
>>> +// so that the print function can keep track.
>>
>> The standard style for multi-line comments is:
>>
>> /*
>>  * Bla bla bla
>>  * bla bla
>>  * foo foo
>>  */
> Ah, thanks.  Will fix it and resubmit.

Some more tips:

- The Subject should be something like: ASoC: fsl_ssi: Fix fsl_ssi
interrupt reporting

- Then run  ./scripts/checkpatch.pl 0001-yourpatch.patch to see
potential issues. The // comment issue would be reported by checkpatch

- Also run  ./scripts/get_maintainer.pl 0001-yourpatch.patch so that
you get the correct people to Cc the patch too. The email address you
put for Timur is no longer valid and Nicolin must be on Cc.

Regards,

Fabio Estevam


More information about the Alsa-devel mailing list