[alsa-devel] [PATCH v2 2/6] ASoC: hdac-hdmi: Add hdmi driver

[Koul, Vinod]

On Mon, 2015-10-26 at 08:29 +0100, Takashi Iwai wrote:
> On Mon, 26 Oct 2015 02:07:49 +0100,
> Vinod Koul wrote:
> > +/*
> > + * Parse all nodes and store the cvt/pin nids in array
> > + * Add one time initialization for pin and cvt widgets
> > + */
> > +static int hdac_hdmi_parse_and_map_nid(struct hdac_ext_device *edev)
> > +{
> ....
> > +	/*
> > +	 * Currently on board only 1 pin and 1 converter enabled.
> > +	 * So using fixed map for dai_id:pin:cvt
> > +	 */
> > +	return hdac_hdmi_init_dai_map(edev, &hdmi->dai_map[0], hdmi->pin_nid[0],
> > +			hdmi->cvt_nid[0], 0);
> 
> Isn't this assumption too naive?
> And such a restriction has to be written more clearly in the
> changelog.

The intention here in this series is to have basic HDMI features enabled :) The
intention is to keep adding stuff to support multichannel, IEC, multiple outputs, SW
notification etc once basic driver is merged

Agreed we can add this to changelog. I can send updated rev, once I have other
comments

-- 
~Vinod