[alsa-devel] [PATCH] ASoC: topology: Reenable use from userspace

Takashi Iwai tiwai at suse.de
Mon Oct 26 08:30:55 CET 2015


On Mon, 26 Oct 2015 04:41:40 +0100,
Mark Brown wrote:
> 
> We had inserted a #error into the topology UAPI code to ensure that the
> ABI was not adopted by userspace while final review and testing was
> ongoing.  Since we are now comfortable that the ABI is suitable for
> production remove the #error, future changes will include provision for
> backwards compatibility.
> 
> Signed-off-by: Mark Brown <broonie at kernel.org>
> ---
> 
> Are we OK with this?  Looking for some acks and reviews...

Don't forget to add this entry to include/uapi/sound/Makefile.
Otherwise it's useless...


Takashi

>  include/uapi/sound/asoc.h | 6 ------
>  1 file changed, 6 deletions(-)
> 
> diff --git a/include/uapi/sound/asoc.h b/include/uapi/sound/asoc.h
> index 247c50b..51b8066 100644
> --- a/include/uapi/sound/asoc.h
> +++ b/include/uapi/sound/asoc.h
> @@ -18,12 +18,6 @@
>  #include <linux/types.h>
>  #include <sound/asound.h>
>  
> -#ifndef __KERNEL__
> -#error This API is an early revision and not enabled in the current
> -#error kernel release, it will be enabled in a future kernel version
> -#error with incompatible changes to what is here.
> -#endif
> -
>  /*
>   * Maximum number of channels topology kcontrol can represent.
>   */
> -- 
> 2.6.1
> 


More information about the Alsa-devel mailing list