[alsa-devel] [PATCH] ALSA: USB-audio: Add support for Novation Nocturn MIDIcontrol surface

Ricard Wanderlof ricard.wanderlof at axis.com
Sun Oct 18 08:30:07 CEST 2015


On Fri, 16 Oct 2015, Clemens Ladisch wrote:

> Ricard Wanderlof wrote:
> > I've noticed that checkpatch complains about the space between the & and (,
> > but in the interest of consistency I've not changed this. Is there some
> > reason for the space
> 
> Yes.   But it's not a particularly substantial reason,

... and what is it pray tell ...? ;-)

> and you're not the first person to mention this checkpatch complaint, so 
> feel free to kill them.
> 
> > would it be worth while cleaning up the file?
> 
> Yes, it would be worth while cleaning up the file by restoring the
> proper VID/PID order of the entries.  :)

I hadn't even noticed that. I suppose it does not really make that much of 
a difference, as if you're looking for a specific device you'd just do an 
ordinary search through the file. But of course it makes sense if nothing 
else as it makes it clear exactly where to add a new entry.

/Ricard
-- 
Ricard Wolf Wanderlöf                           ricardw(at)axis.com
Axis Communications AB, Lund, Sweden            www.axis.com
Phone +46 46 272 2016                           Fax +46 46 13 61 30


More information about the Alsa-devel mailing list