[alsa-devel] [patch] ASoC: wm8960: harmless underflow in wm8960_put_deemph()

Dan Carpenter dan.carpenter at oracle.com
Tue Oct 13 09:09:38 CEST 2015


Valid values of "deemph" are zero and one, but we accidentally allow
negative values as well.  It's harmless but we may as well fix it.

Signed-off-by: Dan Carpenter <dan.carpenter at oracle.com>

diff --git a/sound/soc/codecs/wm8960.c b/sound/soc/codecs/wm8960.c
index e3b7d0c..dc47c2f 100644
--- a/sound/soc/codecs/wm8960.c
+++ b/sound/soc/codecs/wm8960.c
@@ -201,7 +201,7 @@ static int wm8960_put_deemph(struct snd_kcontrol *kcontrol,
 {
 	struct snd_soc_codec *codec = snd_soc_kcontrol_codec(kcontrol);
 	struct wm8960_priv *wm8960 = snd_soc_codec_get_drvdata(codec);
-	int deemph = ucontrol->value.integer.value[0];
+	unsigned int deemph = ucontrol->value.integer.value[0];
 
 	if (deemph > 1)
 		return -EINVAL;


More information about the Alsa-devel mailing list