[alsa-devel] [PATCH v3] ALSA: usb-audio: Fix max packet size calculation for USB audio

[Takashi Iwai]

On Sun, 11 Oct 2015 16:58:11 +0200,
Ricard Wanderlof wrote:
> 
> 
> On Sun, 11 Oct 2015, Takashi Iwai wrote:
> 
> > > The code as it stands has the following expression on line 613 to 
> > > calculate the maximum isochronous packet size:
> > > ...
> > > size which triggered the if statement to start with.
> > 
> > The whole text should be put in the changelog.  That's what Clemens
> > suggested implicitly.  There is no reason to hide such a precious
> > information for later readers.
> 
> Yeah, I wasn't sure exactly what Clemens was hinting at.
> 
> You mean put the whole thing in the commit message? I can certainly do 
> tha. It feels a bit excessive, to me it seemed that once the expression is 
> correct a short commit message should suffice explaining what it does, but 
> in order to convince potential reviewers (and provide a starting point for 
> discussion) an explanation of the proposed change is needed in order to 
> get the patch applied.
> 
> But I can certainly rework it and put it in the commit message instead.

It's up to you.  The text can be a bit brushed up, indeed, for
including in the changelog, but it's far better than too short.  The
background information and detailed explanation are always helpful,
especially when people read through the commits.

So yes, I'll wait for a revised version.


thanks,

Takashi

> 
> /Ricard
> -- 
> Ricard Wolf Wanderlöf                           ricardw(at)axis.com
> Axis Communications AB, Lund, Sweden            www.axis.com
> Phone +46 46 272 2016                           Fax +46 46 13 61 30
>