[alsa-devel] [PATCH V5 1/2] ACPI / EC: Fix broken 64bit big-endian users of 'global_lock'

Greg Kroah-Hartman gregkh at linuxfoundation.org
Sun Oct 4 11:54:01 CEST 2015


On Sun, Sep 27, 2015 at 03:48:24PM +0200, Rafael J. Wysocki wrote:
> On Sun, Sep 27, 2015 at 12:04 AM, Viresh Kumar <viresh.kumar at linaro.org> wrote:
> > global_lock is defined as an unsigned long and accessing only its lower
> > 32 bits from sysfs is incorrect, as we need to consider other 32 bits
> > for big endian 64-bit systems. There are no such platforms yet, but the
> > code needs to be robust for such a case.
> >
> > Fix that by changing type of 'global_lock' to u32.
> >
> > Signed-off-by: Viresh Kumar <viresh.kumar at linaro.org>
> 
> Acked-by: Rafael J. Wysocki <rafael.j.wysocki at intel.com>
> 
> Greg, please take this one along with the [2/2] if that one looks good to you.

Thanks, will do.

greg k-h


More information about the Alsa-devel mailing list