[alsa-devel] [PATCH V2 3/3] ASoC: fsl_asrc: spba clock is needed by asrc device

Nicolin Chen nicoleotsuka at gmail.com
Fri Nov 20 23:00:16 CET 2015


On Fri, Nov 20, 2015 at 08:29:46AM -0600, Rob Herring wrote:
> On Fri, Nov 20, 2015 at 02:17:53PM +0800, Shengjiu Wang wrote:
> > ASRC need to enable the spba clock, when sdma is using share peripheral
> > script. In this case, there is two spba master port is used, if don't
> > enable the clock, the spba bus will have arbitration issue, which may
> > cause read/write wrong data from/to ASRC registers
> > 
> > Signed-off-by: Shengjiu Wang <shengjiu.wang at freescale.com>
> > ---
> >  Documentation/devicetree/bindings/sound/fsl,asrc.txt |  2 ++
> >  sound/soc/fsl/fsl_asrc.c                             | 10 ++++++++++
> >  sound/soc/fsl/fsl_asrc.h                             |  1 +
> >  3 files changed, 13 insertions(+)
> > 
> > diff --git a/Documentation/devicetree/bindings/sound/fsl,asrc.txt b/Documentation/devicetree/bindings/sound/fsl,asrc.txt
> > index b93362a..d8eeee3 100644
> > --- a/Documentation/devicetree/bindings/sound/fsl,asrc.txt
> > +++ b/Documentation/devicetree/bindings/sound/fsl,asrc.txt
> > @@ -25,6 +25,8 @@ Required properties:
> >  	"mem"		  Peripheral access clock to access registers.
> >  	"ipg"		  Peripheral clock to driver module.
> >  	"asrck_<0-f>"	  Clock sources for input and output clock.
> > +	"spba"		  The spba clock is needed when two spba master port
> > +			  is used.
> 
> I'm assuming the same comments on patch 1 apply to all 3.

Yes. I should have mentioned that.

Nicolin


More information about the Alsa-devel mailing list