[alsa-devel] [PATCH 1/4] topology: Remove unused function write_data_block()

[Takashi Iwai]

On Wed, 18 Nov 2015 08:22:59 +0100,
mengdong.lin at linux.intel.com wrote:
> 
> From: Mengdong Lin <mengdong.lin at linux.intel.com>
> 
> Fix gcc warning: 'write_data_block' defined but not used
> [-Wunused-function].
> 
> Signed-off-by: Mengdong Lin <mengdong.lin at linux.intel.com>

I thought this was kept intentionally for the future use.
But it's fine to remove if you are OK, of course.

Applied now.  Thanks.


Takashi

> 
> diff --git a/src/topology/builder.c b/src/topology/builder.c
> index 154bd63..b0ba54e 100644
> --- a/src/topology/builder.c
> +++ b/src/topology/builder.c
> @@ -82,30 +82,6 @@ static int write_block_header(snd_tplg_t *tplg, unsigned int type,
>  	return bytes;
>  }
>  
> -static int write_data_block(snd_tplg_t *tplg, int size, int tplg_type,
> -	const char *obj_name, void *data)
> -{
> -	int ret;
> -
> -	/* write the header for this block */
> -	ret = write_block_header(tplg, tplg_type, 0,
> -		tplg->version, 0, size, 1);
> -	if (ret < 0) {
> -		SNDERR("error: failed to write %s block %d\n", obj_name, ret);
> -		return ret;
> -	}
> -
> -	verbose(tplg, " %s : write %d bytes\n", obj_name, size);
> -
> -	ret = write(tplg->out_fd, data, size);
> -	if (ret < 0) {
> -		SNDERR("error: failed to write %s %d\n", obj_name, ret);
> -		return ret;
> -	}
> -
> -	return 0;
> -}
> -
>  static int write_elem_block(snd_tplg_t *tplg,
>  	struct list_head *base, int size, int tplg_type, const char *obj_name)
>  {
> -- 
> 2.5.0
>