[alsa-devel] ASoC: Intel: Skylake: Add support for virtual dsp widgets

Dan Carpenter dan.carpenter at oracle.com
Tue Nov 3 12:42:35 CET 2015


Hello Jeeja KP,

This is a semi-automatic email about new static checker warnings.

The patch 9a3b9dc636b0: "ASoC: Intel: Skylake: Add support for 
virtual dsp widgets" from Oct 27, 2015, leads to the following Smatch 
complaint:

sound/soc/intel/skylake/skl-topology.c:453 skl_tplg_bind_sinks()
	 error: we previously assumed 'sink' could be null (see line 452)

sound/soc/intel/skylake/skl-topology.c
   451	
   452		if (!sink)
                     ^^^^
New check.  Reversed?

   453			return skl_tplg_bind_sinks(sink, skl, src_mconfig);
                                                   ^^^^
This is dereferenced inside the function.

   454	
   455		return 0;

regards,
dan carpenter


More information about the Alsa-devel mailing list