[alsa-devel] [PATCH v3 2/6] ASoC: hdac-hdmi: Add hdmi driver

[Mark Brown]

On Tue, Oct 27, 2015 at 04:42:13PM +0900, Vinod Koul wrote:

> +	if (err < 0)
> +		dev_err(&hdac->dev, "Failed to query pcm params for nid: %d\n", cvt->nid);

That looks like the NID is being printed as an error code.

> +	/*
> +	 * Currently on board only 1 pin and 1 converter enabled for
> +	 * simplification, more will be added eventually
> +	 * So using fixed map for dai_id:pin:cvt
> +	 */
> +	return hdac_hdmi_init_dai_map(edev, &hdmi->dai_map[0], hdmi->pin_nid[0],
> +			hdmi->cvt_nid[0], 0);

I'm not entirely sure I understand what this is all doing.  It looks
like it's trying to translate the HDA widget map into a DAPM map which
seems sensible but it appears it's making some simplifying assumptions
about the device it's dealing with?

> +static const struct hda_device_id hdmi_list[] = {
> +	HDA_CODEC_EXT_ENTRY(0x80862809, 0x100000, "Skylake HDMI", 0),
> +	{}
> +};

Which is plausible since it's a driver for a specific HDA CODEC.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 473 bytes
Desc: not available
URL: <http://mailman.alsa-project.org/pipermail/alsa-devel/attachments/20151101/fb0b38d9/attachment.sig>