[alsa-devel] [PATCH 2/5] ASoC: rsnd: make sure it uses lock when it calls rsnd_dai_call

Kuninori Morimoto kuninori.morimoto.gx at renesas.com
Mon May 11 10:44:14 CEST 2015


Hi Mark, Geert

> > >  static int rsnd_rdai_continuance_probe(struct rsnd_priv *priv,
> > >  				       struct rsnd_dai_stream *io)
> > >  {
> > > +	unsigned long flags;
> > >  	int ret;
> > >  
> > > +	rsnd_lock(priv, flags);
> > > +
> > >  	ret = rsnd_dai_call(probe, io, priv);
> > >  	if (ret == -EAGAIN) {
> > >  		/*
> > 
> > This causes the following warning on r8a7791/koelsch:
> 
> Thank you for pointing this.
> I will check/fixup it.

I checked about this issue.
Indeed these locks are not needed.
# 2 lock have issue when boot,
# 2 lock has issue when unbind/rmmod/probe fail
# 1 lock is not needed

Mark, is it possible to revert this patch ?

e9c390df671fadc829550935ffb6b23549f26ded
(ASoC: rsnd: make sure it uses lock when it calls rsnd_dai_call)

Best regards
---
Kuninori Morimoto


More information about the Alsa-devel mailing list