[alsa-devel] [PATCH 4/6] ASoC: rt5645: add device tree support

[Mark Brown]

On Thu, Apr 30, 2015 at 06:18:45PM +0800, Bard Liao wrote:

> +- realtek,dmic-en : Boolean. Indicate DMIC is used.

Why is this in DT as opposed to being configured by the DAPM routing or
something - what is the concrete effect of this?  Also...

> +- realtek,dmic1-data-pin
> +- realtek,dmic2-data-pin
> +  Indicate which pin is used for each DMIC.

...should it be combined with these (eg, if one of these properties is
specified should that imply that DMIC is enabled)?  We should also have
something saying what the value for these properties is.

> +- realtek,en-jd-func
> +  Boolean. Indicate if codec IRQ is used or not. It is usually used for JD
> +  and/or headset button detection.

I'm not sure I understand what this is for?  I'd expect that the
interrupt would be used if specified, though if a GPIO is specified I
guess that'd override it.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 473 bytes
Desc: Digital signature
URL: <http://mailman.alsa-project.org/pipermail/alsa-devel/attachments/20150501/ce54bd42/attachment.sig>