[alsa-devel] [PATCH 1/2] ASoC: rt5670: Add disabled item in dmic pin enum

Bard Liao bardliao at realtek.com
Tue Mar 3 09:34:09 CET 2015


> -----Original Message-----
> From: Mark Brown [mailto:broonie at kernel.org]
> Sent: Saturday, February 21, 2015 5:31 PM
> To: Bard Liao
> Cc: lgirdwood at gmail.com; alsa-devel at alsa-project.org; Flove; Oder
> Chiou; John Lin; mengdong.lin at intel.com; yao.jin at intel.com
> Subject: Re: [PATCH 1/2] ASoC: rt5670: Add disabled item in dmic pin
> enum
> 
> On Tue, Feb 17, 2015 at 01:59:26PM +0800, Bard Liao wrote:
> > Currently, we will configure dmic related pin definition if
> > pdata.dmic_en is true. However, there is no disable option in the
> > enum. So, any dmic is used, all 3 dmic related pins will be
> > configured. It may cause unexpected
> 
> Applied both, thanks.  I really appreciate the much better changelogs I'm
> seeing in your recent patches!

Does "[PATCH 2/2] ASoC: rt5670: Fix the speaker mono output issue" patch
also be applied? I see " [PATCH 1/2] ASoC: rt5670: Add disabled item in dmic
pin enum" in topic/rt5670 branch, but don't see "[PATCH 2/2] ASoC: rt5670:
Fix the speaker mono output issue".

> 
> ------Please consider the environment before printing this e-mail.


More information about the Alsa-devel mailing list