[alsa-devel] [PATCH 2/2] ASoC: wm8804: Add DAPM widgets for SPDIF/AIF

[Mark Brown]

On Mon, Mar 02, 2015 at 05:57:55PM +0000, Charles Keepax wrote:

> Firstly, 'Input Source' changes names to 'Tx Source' this is a
> lot clearer, but perhaps we shouldn't change this, as it doesn't
> have to change?

Yes, leave it be.  If you were renaming this should be in the changelog
with an explanation as to why.

> Secondly, the patch removes the controls 'TX Playback Switch' and
> 'AIF Playback Switch' as these bits are controlled by DAPM now. I
> wasn't sure if it would be preferrable to leave dummy controls that
> do nothing?

This sounds like you need a more detailed changelog entry explaining why
it's a good idea to do this in the first place, never mind the proxy
control - what is the purpose of this change and what benefit will it
bring?  Given that this is a S/PDIF bridge it's not at all obvious that
the chip will be used in applications where the sort of power savings
you're likely to see from powering down one of the links (as opposed to
cutting the power to the chip) are likely to register.  Why move those
bits to DAPM control at all?

I also note that this patch is apparently written by but not CCed to
Sapthagiri Baratam.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 473 bytes
Desc: Digital signature
URL: <http://mailman.alsa-project.org/pipermail/alsa-devel/attachments/20150302/152f140d/attachment.sig>