[alsa-devel] [PATCH v2 1/2] ASoC: soc-compress: add a config item for soc-compress

[Qais Yousef]

On 06/16/2015 05:17 PM, Takashi Iwai wrote:
> At Tue, 16 Jun 2015 18:14:40 +0200,
> Takashi Iwai wrote:
>> At Tue, 16 Jun 2015 17:06:07 +0100,
>> Mark Brown wrote:
>>> On Tue, Jun 16, 2015 at 12:36:16PM +0000, Jie, Yang wrote:
>>>
>>>>> OK, that should have been in the commit message.
>>>> OK, so let me add it to the commit message and resend?
>>> Well, there's still the stubs to consider.  Should we really be
>>> returning an error or should we silently ignore the error and hide the
>>> DAI if the user deconfigured compressed audio?  Or rearrange things so
>>> we don't need stubs?  Given that the machine driver has to select
>>> compressed support it's not something that should ever really hit the
>>> stubs, it's not truly a runtime thing...
>> Yes, I guess that leaving without dummy function will give unresolved
>> symbol errors at module link time, so the user can catch before
>> actually running it.  Of course, this should be checked actually.
> Oh, scratch this.  It won't work well in the current code.
> Possibly with weak linking, but...

I don't know if I am missing something, but am I the only one who thinks 
these patches and the proposed changes are too complex for what seems to 
be little gain? Why is it that bad to always compile in soc-compress?

Qais

>
> Takashi
> _______________________________________________
> Alsa-devel mailing list
> Alsa-devel at alsa-project.org
> http://mailman.alsa-project.org/mailman/listinfo/alsa-devel