[alsa-devel] [PATCH v9 2/3] ALSA: hdac_ext: add hdac extended controller

Takashi Iwai tiwai at suse.de
Thu Jun 11 11:10:24 CEST 2015


At Thu, 11 Jun 2015 14:11:48 +0530,
Vinod Koul wrote:
> 
> +struct hdac_ext_link *snd_hdac_ext_bus_get_link(struct hdac_ext_bus *ebus,
> +						 const char *codec_name)
> +{
> +	int i;
> +	struct hdac_ext_link *hlink = NULL;
> +	int bus_idx, addr;
> +
> +	if (sscanf(codec_name, "ehdaudio%dD%d", &bus_idx, &addr) != 2)
> +		return NULL;
> +	if (ebus->idx != bus_idx)
> +		return NULL;
> +
> +	list_for_each_entry(hlink, &ebus->hlink_list, list) {
> +		for (i = 0; i < HDA_MAX_CODECS; i++) {
> +			if (hlink->lsdiid && (0x1 << addr))

This should be single '&'.

But I can correct it by myself at applying, so no need for resend if
no other problem is seen.


Takashi


More information about the Alsa-devel mailing list