[alsa-devel] [PATCH v3 0/9] ASoC: tas2552: Fixes, cleanups and improvements

Peter Ujfalusi peter.ujfalusi at ti.com
Mon Jun 8 14:19:47 CEST 2015


Hi,

Changes since v02:
- Dropped already applied patches from v02
- Fix bit shift in the PLL configuration patch (1/9) and add macro for it for
  readability
- New patches since v02:
 - fix module removing and loading issue by calling pm_runtime_disable when the
   module is removed
 - Remove extra semicolon
 - Consitent naming for 'struct tas2552_data': tas_data -> tas2552
 - Binding document update regarding to the added header file for clock
   selection

Changes since v01:
- missing patch found. It was merged with the previous patch while fixing
  checkpatch errors (patch 19 got squashed to patch 18)
- Sorry for this.

I have used the TAS2552-EVM to verify that my setup is in working condition for
a work on other audio product.
During the bringup of the EVM I have faced some issues and limitation with the
driver. The result is this series against the tas2552 driver.

Notable changes:
- Fixes for kernel crashes
- The enable-gpio was not optional as it was documented in the DTS
- Register bit definitions were not correct in several places
- Adding recommended startup/stop sequence
- Handling of sample formats the driver claims to support
- PLL configuration fixes and reference clock selection
- TDM support
- Gain control fix and control to select DIN source

Regards,
Peter
---
Peter Ujfalusi (9):
  ASoC: tas2552: Correct the PLL configuration
  ASoC: tas2552: Add control for selecting DIN source
  ASoC: tas2552: Correct Output Data register usage
  ASoC: tas2552: Correct Boost Auto-Pass Through Control register usage
  ASoC: tas2552: Code, define alignment changes for uniformity
  ASoC: tas2552: Call pm_runtime_disable when the module is removed
  ASoC: tas2552: Remove unneeded semicolon
  ASoC: tas2552: Use consistent name for 'struct tas2552_data'
  ASoC: tas2552: Update DT binding document regarding clkock
    configuration

 .../devicetree/bindings/sound/tas2552.txt          |   6 +
 sound/soc/codecs/tas2552.c                         | 173 ++++++++++++++-------
 sound/soc/codecs/tas2552.h                         |  61 ++++----
 3 files changed, 155 insertions(+), 85 deletions(-)

-- 
2.4.2



More information about the Alsa-devel mailing list