[alsa-devel] [PATCH] ASoC: wm8731: initialize the hardware when loading the codec driver

Mark Brown broonie at kernel.org
Fri Jun 5 20:27:46 CEST 2015


On Fri, Jun 05, 2015 at 11:20:26AM -0700, Sergey Kiselev wrote:
> Charles Keepax <ckeepax at opensource.wolfsonmicro.com> wrote:
> > On Wed, Jun 03, 2015 at 01:19:26PM -0700, Sergey Kiselev wrote:

> > >  	/* Regulators will have been enabled by bias management */

> > This comment needs an update because this function is only called
> > from the bus probe so no bias management will have been called
> > yet. Basically we are powering down here after probe is complete
> > and the bias management will power us up again.

> I think that's what the comment says (future perfect tense?!). I can
> rephrase it with something simpler like "regulators will be enabled by
> bias management". English is not my mother tongue, and I appreciate any
> corrections. :-)

Yes, will be is better - it binds "will (have been)", that is "it will
at this time be the case that the regulators have been enabled".
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 473 bytes
Desc: Digital signature
URL: <http://mailman.alsa-project.org/pipermail/alsa-devel/attachments/20150605/08374578/attachment.sig>


More information about the Alsa-devel mailing list