[alsa-devel] [PATCH] ASoC: rt5677: Avoid recursive locking in the DEADLOCK detector

Mark Brown broonie at kernel.org
Fri Jun 5 12:31:44 CEST 2015


On Fri, Jun 05, 2015 at 08:53:54AM +0800, Nicolas Boichat wrote:

> > Could you be more specific about the deadlock you're seeing?  This isn't
> > really enough to understand either what the problem is or why this fixes
> > it.  Converting all the per-regmap mutexes into a single global mutex
> > isn't an immediately obvious step.

> We originally reported the issue to Realtek:

Any analysis needs to be in the changelog for the commit and...

> I suggested reworking the register read/write calls in rt5677.c to
> direct them to the correct regmap earlier on (rt5677->regmap or
> rt5677->regmap_physical), before locks are acquired. But the patch
> above also fixes the issue (that is, it removes the warning).

...the above sounds like there's a bug in the locking anyway which this
is just a bodge for?
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 473 bytes
Desc: Digital signature
URL: <http://mailman.alsa-project.org/pipermail/alsa-devel/attachments/20150605/6c13ba8e/attachment.sig>


More information about the Alsa-devel mailing list