[alsa-devel] [PATCH v4 5/7] ASoC: intel - add Skylake HDA audio driver

[Takashi Iwai]

At Tue, 2 Jun 2015 11:45:16 +0100,
Mark Brown wrote:
> 
> On Fri, May 29, 2015 at 08:25:01PM +0200, Takashi Iwai wrote:
> > Mark Brown wrote:
> 
> > > > +/* PCI register access. */
> > > > +static void pci_azx_writel(u32 value, u32 __iomem *addr)
> > > > +{
> > > > +	writel(value, addr);
> > > > +}
> 
> > > These wrappers are setting off alarm bells - why can't we just use the
> > > called functions directly, and given the parameters (which have just a
> > > raw pointer and value) what else could the implementation be?
> 
> > Tegra has no direct byte access but only aligned 32bit accesses.
> > That's why we have the redirection.
> 
> Ugh, and the functions are macros so can't be used directly.  I'd still
> expect to see these ops be defined in some central place and reused.

Maybe we can lift up some time later, but it's nothing more than an
optimization, so in a low priority for now.


Takashi