[alsa-devel] [PATCH] ASoC: cs4349: Fix setting digital interface format

Tim Howe tim.howe at cirrus.com
Thu Jul 30 23:33:49 CEST 2015



On Sun, 19 Jul 2015, Axel Lin wrote:

> Mode Control - Register 02h
> 
> Digital Interface Format (DIF[2:0]) Bits 6-4
> 
> DIF2    DIF1    DIF0    Description
> 0       0       0       Left-Justified, up to 24-bit data
> 0       0       1       I²S, up to 24-bit data
> 0       1       0       Right-Justified, 16-bit data
> 0       1       1       Right-Justified, 24-bit data
> 1       0       0       TDM slot 0
> 1       0       1       TDM slot 1
> 1       1       0       TDM slot 2
> 1       1       1       TDM slot 3
> 
> The DIF_MASK is 0x70, so current code does not correctly set the DIFx
> setting. Fix it.
> 
> Signed-off-by: Axel Lin <axel.lin at ingics.com>
> ---
> I assume the path "ASoC: cs4349: Don't use rtd->codec" will be applied
> first, so this patch is on top of that patch.
> 
>  sound/soc/codecs/cs4349.c | 11 +++++------
>  1 file changed, 5 insertions(+), 6 deletions(-)
> 
Good catch, thanks!
Acked-by: Tim Howe <tim.howe at cirrus.com>


More information about the Alsa-devel mailing list