[alsa-devel] [PATCH RFT] ASoC: sgtl5000: Fix up define for SGTL5000_SMALL_POP

[Zeng Zhaoming]

On Wed, Jul 22, 2015 at 11:27 AM, Axel Lin <axel.lin at ingics.com> wrote:
> Currently, below code actually does not update any bit because
> SGTL5000_SMALL_POP is 0.
>
> snd_soc_update_bits(codec, SGTL5000_CHIP_REF_CTRL, SGTL5000_SMALL_POP, 1);
>
> The SGTL5000_SMALL_POP should be BIT(0) rather than 0, fix it.
>
> Signed-off-by: Axel Lin <axel.lin at ingics.com>
> ---
> Hi,
> I don't have h/w and datasheet, but the code looks obvious does not make
> sense. Can someone help to confirm and test if this patch?
> Thanks,
> Axel
>  sound/soc/codecs/sgtl5000.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/sound/soc/codecs/sgtl5000.h b/sound/soc/codecs/sgtl5000.h
> index bd7a344..1c317de 100644
> --- a/sound/soc/codecs/sgtl5000.h
> +++ b/sound/soc/codecs/sgtl5000.h
> @@ -275,7 +275,7 @@
>  #define SGTL5000_BIAS_CTRL_MASK                        0x000e
>  #define SGTL5000_BIAS_CTRL_SHIFT               1
>  #define SGTL5000_BIAS_CTRL_WIDTH               3
> -#define SGTL5000_SMALL_POP                     0
> +#define SGTL5000_SMALL_POP                     1
>
>  /*
>   * SGTL5000_CHIP_MIC_CTRL
> --
> 2.1.0
>
>
>

Thanks for your report, seems your are right. I have no board to test it.

The code introduced by c251ea7bd7a04f1f2575467e0de76e803cf59149.
Fabio, can you verify it on mx28evk?

Thanks

-- 
Best Regards
    Zeng Zhaoming