[alsa-devel] [PATCH 7/7] sound/usb: Update ALSA driver to use Managed Media Controller API

[Shuah Khan]

On 07/20/2015 03:00 AM, Takashi Iwai wrote:
> On Mon, 20 Jul 2015 10:47:46 +0200,
> Dan Carpenter wrote:
>>
>> On Tue, Jul 14, 2015 at 06:34:06PM -0600, Shuah Khan wrote:
>>> +		ret = media_entity_setup_link(link, flags);
>>> +		if (ret) {
>>> +			dev_err(mctl->media_dev->dev,
>>> +				"Couldn't change tuner link",
>>> +				"%s->%s to %s. Error %d\n",
>>
>> Add a space after "link".
>>
>> 				"Couldn't change tuner link ",
>> 				"%s->%s to %s. Error %d\n",
> 
> Such a message string would be better to be in a single line even if
> it's over 80 chars.  Otherwise it becomes hard to grep.
> 

Right. The above generates a warning and I found it after I sent
the patch. I will have to re-do this patch to fix this. I prefer
not splitting the message, but checkpatch compains if I don't.

thanks,
-- Shuah

-- 
Shuah Khan
Sr. Linux Kernel Developer
Open Source Innovation Group
Samsung Research America (Silicon Valley)
shuahkh at osg.samsung.com | (970) 217-8978