[alsa-devel] [PATCH 6/7] media: au0828 change to use Managed Media Controller API

[Dan Carpenter]

Sorry for this nit-pick and some time after you sent this patch.  It's
not a redo the patch" complaint, it's something that could be fixed
later.

On Tue, Jul 14, 2015 at 06:34:05PM -0600, Shuah Khan wrote:
> @@ -131,10 +132,12 @@ static void au0828_unregister_media_device(struct au0828_dev *dev)
>  {
>  
>  #ifdef CONFIG_MEDIA_CONTROLLER
> -	if (dev->media_dev) {
> -		media_device_unregister(dev->media_dev);
> -		kfree(dev->media_dev);
> -		dev->media_dev = NULL;
> +	if (dev->media_dev &&
> +		media_devnode_is_registered(&dev->media_dev->devnode)) {
> +			media_device_unregister_entity_notify(dev->media_dev,
> +							&dev->entity_notify);
> +			media_device_unregister(dev->media_dev);
> +			dev->media_dev = NULL;


The indenting is slightly off here.  It should be:

	if (dev->media_dev &&
	    media_devnode_is_registered(&dev->media_dev->devnode)) {
		media_device_unregister_entity_notify(dev->media_dev,
						      &dev->entity_notify);
		media_device_unregister(dev->media_dev);
		dev->media_dev = NULL;
	}

Aligning if statements using spaces like that is nicer and checkpatch.pl
won't complain.

regards,
dan carpenter