[alsa-devel] [PATCH RFT] ASoC: sgtl5000: Fix up define for SGTL5000_SMALL_POP

[Axel Lin]

2015-07-22 16:58 GMT+08:00 Alexander Stein
<alexander.stein at systec-electronic.com>:
> On Wednesday 22 July 2015 11:27:45, Axel Lin wrote:
>> Currently, below code actually does not update any bit because
>> SGTL5000_SMALL_POP is 0.
>>
>> snd_soc_update_bits(codec, SGTL5000_CHIP_REF_CTRL, SGTL5000_SMALL_POP, 1);
>>
>> The SGTL5000_SMALL_POP should be BIT(0) rather than 0, fix it.
>>
>> Signed-off-by: Axel Lin <axel.lin at ingics.com>
>
> I can not test this right now, but it seems appropriate.
> Acked-By: Alexander Stein <alexander.stein at systec-electronic.com>
>
>> Hi,
>> I don't have h/w and datasheet, but the code looks obvious does not make
>> sense. Can someone help to confirm and test if this patch?
>
> The datasheet can be found online: http://www.freescale.com/webapp/sps/site/prod_summary.jsp?code=SGTL5000&fpsp=1&tab=Documentation_Tab

I just checked the datasheet and confirm the SMALL_POP is BIT(0).
Thanks,
Axel