[alsa-devel] ASoC: rsnd: show debug message for SSI/SRC/DVC connection

Dan Carpenter dan.carpenter at oracle.com
Mon Jul 20 23:45:40 CEST 2015


Hello Kuninori Morimoto,

This is a semi-automatic email about new static checker warnings.

The patch 84e95355602c: "ASoC: rsnd: show debug message for 
SSI/SRC/DVC connection" from Jul 15, 2015, leads to the following 
Smatch complaint:

sound/soc/sh/rcar/core.c:338 rsnd_dai_connect()
	 warn: variable dereferenced before check 'mod' (see line 335)

sound/soc/sh/rcar/core.c
   334	{
   335		struct rsnd_priv *priv = rsnd_mod_to_priv(mod);
                                         ^^^^^^^^^^^^^^^^^^^^^
Patch adds new dereference.

   336		struct device *dev = rsnd_priv_to_dev(priv);
   337	
   338		if (!mod)
                    ^^^^
Existing code assumed "mod" could be NULL.

   339			return -EIO;
   340	

regards,
dan carpenter


More information about the Alsa-devel mailing list