[alsa-devel] HDMI hotplug on Skylake when power well is off

[Takashi Iwai]

On Fri, 17 Jul 2015 13:14:29 +0200,
Vinod Koul wrote:
> 
> On Thu, Jul 16, 2015 at 03:37:07PM +0200, David Henningsson wrote:
> > +static void i915_audio_component_hotplug_notify(struct hdac_bus *bus,
> > +	const struct i915_audio_hotplug_info *info)
> > +{
> > +	struct hda_codec *codec;
> this should be hdac_device as core doesnt know hda_codec

Yes, hdac_device is the core part of the codec device struct.

> > +
> > +	codec_dbg("Received HDMI hotplug callback (connector = %s, plugged in = %d)",
> > +		  info->connector_name, (int) info->plugged_in);
> > +
> > +	for (i = 0; i <= MAX_CODEC_ADDRESS; i++)
> > +		if (bus->caddr_tbl[i] && bus->caddr_tbl[i]->hotplug_notify)
> > +			bus->caddr_tbl[i]->hotplug_notify(bus->caddr_tbl[i], info);
> > +}
> 
> Rest looks good :)

I prefer traversing over the list like:

	struct hdac_device *codec;

	list_for_each_entry(codec, &bus->list, list) {
		if (codec->hotplug_notify)
			codec->hotplug_notify(codec, info);
	}


thanks,

Takashi