[alsa-devel] [PATCH 2/2 V5] regmap: Apply optional delay in multi_reg_write/register_patch

Mark Brown broonie at kernel.org
Thu Jul 16 22:55:22 CEST 2015


On Thu, Jul 16, 2015 at 04:36:22PM +0100, Nariman Poushin wrote:

> +
> +			if (regs[i].delay_us)
> +				udelay(regs[i].delay_us);

This is a bit funky.  While Takashi is correct that we could be running
in a spinlock equally this will mean that we could end up with some
really long busy waits.  It feels like we should at least make an effort
to complain about that, print a warning or something.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 473 bytes
Desc: Digital signature
URL: <http://mailman.alsa-project.org/pipermail/alsa-devel/attachments/20150716/006edd00/attachment.sig>


More information about the Alsa-devel mailing list