[alsa-devel] [PATCH 4/7] media: change dvb-frontend to honor MC tuner enable error

Shuah Khan shuahkh at osg.samsung.com
Wed Jul 15 02:34:03 CEST 2015


Change dvb_frontend_thread() to honor MC tuner enable error and
return as opposed to ignoring the error and continuing to use it.

Signed-off-by: Shuah Khan <shuahkh at osg.samsung.com>
---
 drivers/media/dvb-core/dvb_frontend.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/drivers/media/dvb-core/dvb_frontend.c b/drivers/media/dvb-core/dvb_frontend.c
index 842b9c8..5a86211 100644
--- a/drivers/media/dvb-core/dvb_frontend.c
+++ b/drivers/media/dvb-core/dvb_frontend.c
@@ -713,9 +713,8 @@ static int dvb_frontend_thread(void *data)
 #ifdef CONFIG_MEDIA_CONTROLLER_DVB
 	ret = dvb_enable_media_tuner(fe);
 	if (ret) {
-		/* FIXME: return an error if it fails */
-		dev_info(fe->dvb->device,
-			"proceeding with FE task\n");
+		dev_err(fe->dvb->device, "Tuner is busy. Error %d\n", ret);
+		return ret;
 	} else if (fepriv->pipe_start_entity) {
 		ret = media_entity_pipeline_start(fepriv->pipe_start_entity,
 						  &fepriv->pipe);
-- 
2.1.4



More information about the Alsa-devel mailing list