[alsa-devel] [PATCH 2/2] ASoC: fsl_dma: Do not use 'full_name' node reference

Timur Tabi timur at tabi.org
Wed Jan 7 18:54:07 CET 2015


Fabio Estevam wrote:
> -        dev_err(&pdev->dev, "could not determine resources for %s\n",
> -            ssi_np->full_name);
> +        dev_err(&pdev->dev, "could not determine resources: %d\n", ret);

I remember now why I did this, and I might need to NACK this patch. 
ssi_np->full_name is the name of the SSI node, but here, dev_err will 
print the name of the DMA node.  So the intent is to help the user 
determine which SSI node has a broken DMA node pointer.  This probably 
is useful only on PowerPC, which uses the old ssi->dma linkage.


More information about the Alsa-devel mailing list