[alsa-devel] [PATCH 2/2] ASoC: fsl_dma: Do not use 'full_name' node reference

Timur Tabi timur at tabi.org
Wed Jan 7 18:26:44 CET 2015


Fabio Estevam wrote:
> -			ssi_np->full_name);
> +			pdev->name);
>   		of_node_put(ssi_np);
>   		return ret;
>   	}
>
> -	dma = kzalloc(sizeof(*dma) + strlen(np->full_name), GFP_KERNEL);
> +	dma = kzalloc(sizeof(*dma), GFP_KERNEL);

Something is missing here.  Since we're no longer allocating space in 
the 'dma' object for the name, then you should probably delete the code 
that copies the string to the 'dma' object.


More information about the Alsa-devel mailing list