[alsa-devel] [PATCH] ASoC: Intel: Add NULL checks for the stream pointer

Mark Brown broonie at kernel.org
Wed Jan 7 12:18:11 CET 2015


On Wed, Jan 07, 2015 at 12:53:24AM +0000, Jie, Yang wrote:

> > I'd be much happier if this warned in cases where it wasn't totally obvious that
> > attempting to use a NULL pointer is sensible.

> [Keyon] thanks for review, Mark. So you meant we should add some warning log here, right?

Yes, I'd be a lot happier with that - if there's some cases which happen
a lot and it makes sense that they happen a lot then the changelog
and/or the code should make it clear that those cases are OK but as a
default it seems better to at least say we ignored things.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 473 bytes
Desc: Digital signature
URL: <http://mailman.alsa-project.org/pipermail/alsa-devel/attachments/20150107/858de64c/attachment.sig>


More information about the Alsa-devel mailing list