[alsa-devel] [PATCH 5/6] ASoC: samsung: Extend Snow driver to support max98089

Mark Brown broonie at kernel.org
Thu Feb 19 10:44:25 CET 2015


On Wed, Feb 18, 2015 at 07:25:58PM +0100, Andreas Färber wrote:

>  static const struct of_device_id snow_of_match[] = {
> +	{ .compatible = "google,snow-audio-max98089", },
>  	{ .compatible = "google,snow-audio-max98090", },
>  	{ .compatible = "google,snow-audio-max98091", },
>  	{ .compatible = "google,snow-audio-max98095", },

Since we completely ignore the CODEC in the property might it not be
better to just add a plain old snow-audio compatible and bind to that,
that way we don't need these driver updates?  Just the "snow" bit should
be enough to know it's one of this class of machines.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 473 bytes
Desc: Digital signature
URL: <http://mailman.alsa-project.org/pipermail/alsa-devel/attachments/20150219/738f8ed8/attachment.sig>


More information about the Alsa-devel mailing list