[alsa-devel] [PATCH 1/6] ALSA: line6: Improve line6_read/write_data() interfaces

Chris Rorvick chris at rorvick.com
Wed Feb 11 12:58:06 CET 2015


On Wed, Feb 11, 2015 at 3:33 AM, Takashi Iwai <tiwai at suse.de> wrote:
> At Tue, 10 Feb 2015 23:03:12 -0600,
> Chris Rorvick wrote:
>>
>> Use explicit types to reflect the range of valid values.
>
> Well, this isn't necessarily to be changed at these places.  If we
> want to be safer, there should be proper range checks instead.
> Also, readers may wonder when they see the different types between
> read and write without explanations.

Thanks, I'll send a v2 shortly.


More information about the Alsa-devel mailing list