[alsa-devel] [PATCH v5 05/10] ALSA: core: selection of audio_tstamp type and accuracy reports

Takashi Iwai tiwai at suse.de
Mon Feb 9 16:16:42 CET 2015


At Fri,  6 Feb 2015 15:55:54 -0600,
Pierre-Louis Bossart wrote:
> 
> +static inline void snd_pcm_pack_audio_tstamp_report(__u32 *data, __u32 *accuracy,
> +						struct snd_pcm_audio_tstamp_report *report)

Put const to report argument.


> +{
> +	u32 tmp;
> +
> +	tmp = report->accuracy_report;
> +	tmp <<= 4;
> +	tmp |= report->actual_type;
> +	tmp <<= 1;
> +	tmp |= report->valid;
> +
> +	*data |= (tmp << 16);

Isn't there any zero-clear?


Takashi


More information about the Alsa-devel mailing list