[alsa-devel] [PATCH] ALSA: control: obsolete 'already present' messaging because it's caller's fault

[Takashi Iwai]

At Sun, 08 Feb 2015 12:16:33 +0100,
Takashi Iwai wrote:
> 
> At Sun,  8 Feb 2015 19:29:08 +0900,
> Takashi Sakamoto wrote:
> > 
> > When drivers or userspace applications add a duplicated control, snd
> > module outputs error message and return -EBUSY.
> > 
> > This state is a bug in driver or application, therefore the messaging
> > should be done by them, not by snd module.
> 
> The message should be hidden for user-space actions, indeed, but it's
> been very helpful for the driver developments, so I'm against the
> unconditional removal.
> 
> Also, think what you really suggested: there are almost 500 calls of
> snd_ctl_add() in the tree and you suggest to put the error message to
> each of them.
> 
> Rather try to show the error only for the kernel snd_ctl_add() calls.

Alternatively, the easiest fix would be to change it to dev_dbg().


Takashi