[alsa-devel] [PATCH v3] ASoC: rt286: add jack detection enable/disable APIs and export

[Jie, Yang]

> -----Original Message-----
> From: Michał Mirosław [mailto:mirqus at gmail.com]
> Sent: Friday, February 06, 2015 6:21 PM
> To: Jie, Yang
> Cc: broonie at kernel.org; alsa-devel at alsa-project.org; Girdwood, Liam R
> Subject: Re: [alsa-devel] [PATCH v3] ASoC: rt286: add jack detection
> enable/disable APIs and export
> 
> 2015-02-06 7:40 GMT+01:00 Jie Yang <yang.jie at intel.com>:
> [...]
> > @@ -1012,6 +1039,8 @@ static irqreturn_t rt286_irq(int irq, void *data)
> >         bool mic = false;
> >         int status = 0;
> >
> > +       if (!rt286->jack)
> > +               return IRQ_HANDLED;
> >         rt286_jack_detect(rt286, &hp, &mic);
> >
> >         /* Clear IRQ */
> 
> This seems wrong. Are you sure you want to return IRQ_HANDLED when you
> did nothing to handle the interrupt?
[Keyon] thanks, yes, I also noticed this. The interrupt will keep coming endlessly with returning IRQ_HANDLED here. :(
> 
> Best Regards,
> Michał Mirosław