[alsa-devel] [PATCH v2 03/14] ASoC: hdac_hdmi - Use list to add pins and converters

[Subhransu S. Prusty]

On Thu, Dec 03, 2015 at 04:44:55PM +0100, Takashi Iwai wrote:
> On Thu, 03 Dec 2015 22:08:51 +0100,
> Subhransu S. Prusty wrote:
> >  static int hdac_hdmi_dev_remove(struct hdac_ext_device *edev)
> >  {
> > +	struct hdac_hdmi_priv *hdmi = edev->private_data;
> > +	struct hdac_hdmi_pin *pin;
> > +	struct hdac_hdmi_cvt *cvt;
> > +
> >  	snd_soc_unregister_codec(&edev->hdac.dev);
> >  
> > +	list_for_each_entry(cvt, &hdmi->cvt_list, head) {
> > +		list_del(&cvt->head);
> > +		kfree(cvt);
> > +	}
> > +
> > +	list_for_each_entry(pin, &hdmi->pin_list, head) {
> > +		list_del(&pin->head);
> > +		kfree(pin);
> > +	}
> 
> These must be list_for_each_entry_safe().

Sure. Will change it.

Regards,
Subhransu
> 
> 
> Takashi

--