[alsa-devel] [PATCH 1/4] drm/i915: Add audio pin sense / ELD callback

[Jani Nikula]

On Wed, 19 Aug 2015, David Henningsson <david.henningsson at canonical.com> wrote:
> This callback will be called by the i915 driver to notify the hda
> driver that its HDMI information needs to be refreshed, i e,
> that audio output is now available (or unavailable) - usually as a
> result of a monitor being plugged in (or unplugged).
>
> Signed-off-by: David Henningsson <david.henningsson at canonical.com>
> ---
>  include/drm/i915_component.h | 12 ++++++++++++
>  1 file changed, 12 insertions(+)
>
> diff --git a/include/drm/i915_component.h b/include/drm/i915_component.h
> index c9a8b64..ab5bde37 100644
> --- a/include/drm/i915_component.h
> +++ b/include/drm/i915_component.h
> @@ -34,6 +34,18 @@ struct i915_audio_component {
>  		void (*codec_wake_override)(struct device *, bool enable);
>  		int (*get_cdclk_freq)(struct device *);
>  	} *ops;
> +
> +	const struct i915_audio_component_audio_ops {
> +		void *audio_ptr;
> +		/**
> +		 * Call from i915 driver, notifying the HDA driver that
> +		 * pin sense and/or ELD information has changed.
> +		 * @audio_ptr:		HDA driver object
> +		 * @port:		Which port has changed (PORTA / PORTB / PORTC etc)
> +		 * @port_mst_index:	Index within that port, for DisplayPort multistreaming
> +		 */
> +		void (*pin_eld_notify)(void *audio_ptr, int port, int port_mst_index);

In the HDMI sample rate notification series [1] I explicitly asked Libin
to drop a similar port_mst_index parameter since we don't use it yet,
and we are not sure what to stick there yet. Indeed not having it now
enforces us to change the API and check for each call site when enabling
MST audio.

Other than that,

Reviewed-by: Jani Nikula <jani.nikula at intel.com>



[1] http://mid.gmane.org/1439880714-40931-1-git-send-email-libin.yang@intel.com

> +	} *audio_ops;
>  };
>  
>  #endif /* _I915_COMPONENT_H_ */
> -- 
> 1.9.1
>

-- 
Jani Nikula, Intel Open Source Technology Center