[alsa-devel] [PATCH v4] ASoC: ics43432: Add codec driver for InvenSense ICS-43432 (fwd)

[Ricard Wanderlof]

On Tue, 25 Aug 2015, Mark Brown wrote:

> On Mon, Aug 24, 2015 at 02:03:14PM +0200, Ricard Wanderlof wrote:
> 
> > +static int ics43432_set_dai_fmt(struct snd_soc_dai *dai, unsigned int 
> > +fmt) {
> > +	switch (fmt & SND_SOC_DAIFMT_INV_MASK) {
> > +	case SND_SOC_DAIFMT_NB_NF:
> > +		break;
> > +	default:
> > +		return -EINVAL;
> > +	}
> 
> I've asked you several times to implement format checking in the core if 
> you think it's useful to add :(

Sorry, I misunderstood the outcome of the discussion with you and 
Lars-Peter, to the point that it was better to have that type of checking 
in the core, but in the absence of that (since apparently no one has had 
the need to had it before) it was better to have the check at the driver 
level than not at all.

I'll take it out of the driver and repost.

/Ricard
-- 
Ricard Wolf Wanderlöf                           ricardw(at)axis.com
Axis Communications AB, Lund, Sweden            www.axis.com
Phone +46 46 272 2016                           Fax +46 46 13 61 30