[alsa-devel] [PATCH v2] ASoC: ssm2518: Add explicit device tree support

Mark Brown broonie at kernel.org
Mon Aug 17 19:28:55 CEST 2015


On Mon, Aug 17, 2015 at 08:43:23AM +0200, Ricard Wanderlof wrote:
> On Fri, 14 Aug 2015, Mark Brown wrote:

> > > Add OF match table to SSM2518 to allow direct matching without going
> > > through I2C subsystem.

> > > Signed-off-by: Ricard Wanderlof <ricardw at axis.com>

> > > ---
> > >  sound/soc/codecs/ssm2518.c |    9 +++++++++
> > >  1 file changed, 9 insertions(+)

> > You should document all new DT bindings (even if they did implicitly
> > happen to work before).

> Do you mean in the commit message then? (The patch doesn't implement any 
> bindings not already described in 
> Documentation/devicetree/bindings/sound/ssm2518.txt).

No, I mean the binding file.  In the unusual case that there's one
already that's not had the driver side changes made then you should
mention that it exists in the changelog.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 473 bytes
Desc: Digital signature
URL: <http://mailman.alsa-project.org/pipermail/alsa-devel/attachments/20150817/1dbb29ea/attachment.sig>


More information about the Alsa-devel mailing list