[alsa-devel] [PATCH v2] ASoC: ics43432: Add codec driver for InvenSense ICS-43432

[Ricard Wanderlof]

On Fri, 14 Aug 2015, Mark Brown wrote:

> On Fri, Aug 14, 2015 at 11:10:10AM +0200, Ricard Wanderlof wrote:
> > 
> > V2: Update after comments from Lars-Peter yesterday: set rate to 
> > CONTINUOUS and let ALSA figure out the details, also removing hw_params as 
> > it is then not needed.
> 
> Please add any non-changelog content like this after the --- as covered
> in SubmittingPatches.

Ok, sorry.

> > +static int ics43432_set_dai_fmt(struct snd_soc_dai *dai, unsigned int fmt)
> > +{
> > +	switch (fmt & SND_SOC_DAIFMT_INV_MASK) {
> 
> This still seems redundant (IIRC Lars mentioned this...).

I though Lars was referring solely to the hw_params function, not 
set_dai_fmt, but of course I could have misunderstood him.

I can understand the rates constraints being handled by the ALSA framework 
based on the parameters set in struct snd_soc_dai_driver, but how would 
the framework know about the acceptable INV_MASK and FORMAT_MASK values?

/Ricard
-- 
Ricard Wolf Wanderlöf                           ricardw(at)axis.com
Axis Communications AB, Lund, Sweden            www.axis.com
Phone +46 46 272 2016                           Fax +46 46 13 61 30