[alsa-devel] [PATCH v2 09/10] ASoC: topology: Change stream formats to bitwise flag

[Takashi Iwai]

On Sat, 15 Aug 2015 16:59:04 +0200,
Mark Brown wrote:
> 
> On Sat, Aug 15, 2015 at 09:37:34AM +0200, Takashi Iwai wrote:
> 
> > We can make the topology stuff disabled in Makefile (and the only call
> > in soc-core.c) instead of the whole revert.  This will be the minimal
> > impact and safe enough.
> 
> Yes, though it does leave the UAPI files there for people to look at
> which is a big part of the risk since they end up getting shipped
> separately to the kernel binary.

True, if we want really 120% safety...

> Might be sufficient, though - we could
> just put some #errors in the headers to catch potential users.  Or
> perhaps we're OK with the ABI as it stands.

Yeah, #error or a big fat comment should suffice, I suppose.

> > BTW, I wonder why there is no Kconfig for topology stuff.  If we had
> > it, it would have been easy to disable.
> 
> It's probably worth adding that anyway - I know Intel at least are keen
> on having the capability to minimise memory usage!

Right, I had it in my mind, too.


Takashi