[alsa-devel] [PATCH v9 0/7] ALSA: jack: Refactoring for jack kctls

Jie, Yang yang.jie at intel.com
Fri Apr 24 06:37:45 CEST 2015


> -----Original Message-----
> From: Mark Brown [mailto:broonie at kernel.org]
> Sent: Friday, April 24, 2015 2:18 AM
> To: Jie, Yang
> Cc: Takashi Iwai; alsa-devel at alsa-project.org; Girdwood, Liam R;
> tanu.kaskinen at linux.intel.com
> Subject: Re: [PATCH v9 0/7] ALSA: jack: Refactoring for jack kctls
> 
> On Thu, Apr 23, 2015 at 01:45:07PM +0000, Jie, Yang wrote:
> 
> > Hi, Mark, per my understanding, we didn't create specific kcontrols
> > for each ASoC jack, now, my new change reuse the jack pins' info to
> > create these kcontrols, which can be seen and controlled from upper
> > layer (e.g. PA).
> 
> I have not been keeping up with this series because it's quite large and there
> have been many revisions in a short period of time, along with a large
> number of other substantial patch serieses from your colleagues.
 
I can imagine and understand that. Care yourself, Mark. :)

To simplify it, let me summarize it:
only the patch 5 in the series ([PATCH v9 5/7] ASoC: jack: create kctls according
to jack pins info) change ASoC code, when looking into it, you can find only one
line is added:
+	snd_jack_add_new_kctl(jack->jack, pins[i].pin, pins[i].mask);

So the patch will create extra kcontrols for ASoC jack, comparing to the current
upstream code.

Thanks,
~Keyon


More information about the Alsa-devel mailing list