[alsa-devel] ASoC: davinci-mcasp: Set rule constraints if implicit BCLK divider is used

Jyri Sarha jsarha at ti.com
Mon Apr 13 15:32:24 CEST 2015


On 04/13/15 15:16, Dan Carpenter wrote:
> Thanks for looking at this.  I haven't double checked your analysis, but
> 512 means the stack is 2k and that's too high.  I think there is
> supposed to be a build warning if we use more than 1k of stack in a
> function?
>
> It's better to allocate it with kmalloc() and free it at the end.
>
> regards,
> dan carpenter
>

The function may get called hundreds or even thousands of times when an 
audio stream is started. How heavy is kmalloc/free cycle?

Using kmalloc just feels a bit stupid since in any remotely feasible 
case the maximum number of channels is 8. But maybe I just should not care.

Best regards,
Jyri


More information about the Alsa-devel mailing list