[alsa-devel] [PATCH] ASoC: Intel: fix ifnullfree.cocci warnings

kbuild test robot fengguang.wu at intel.com
Sun Apr 12 21:06:26 CEST 2015


sound/soc/intel/common/sst-ipc.c:287:2-7: WARNING: NULL check before freeing functions like kfree, debugfs_remove, debugfs_remove_recursive or usb_free_urb is not needed. Maybe consider reorganizing relevant code to avoid passing NULL values.

 NULL check before some freeing functions is not needed.

 Based on checkpatch warning
 "kfree(NULL) is safe this check is probably not required"
 and kfreeaddr.cocci by Julia Lawall.

Generated by: scripts/coccinelle/free/ifnullfree.cocci

CC: Jin Yao <yao.jin at linux.intel.com>
Signed-off-by: Fengguang Wu <fengguang.wu at intel.com>
---

 sst-ipc.c |    3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

--- a/sound/soc/intel/common/sst-ipc.c
+++ b/sound/soc/intel/common/sst-ipc.c
@@ -283,8 +283,7 @@ void sst_ipc_fini(struct sst_generic_ipc
 	if (ipc->tx_thread)
 		kthread_stop(ipc->tx_thread);
 
-	if (ipc->msg)
-		kfree(ipc->msg);
+	kfree(ipc->msg);
 }
 EXPORT_SYMBOL_GPL(sst_ipc_fini);
 


More information about the Alsa-devel mailing list