[alsa-devel] [PATCH 3/3] ASoC: Don't try to register debugfs entries if the parent does not exist

Mark Brown broonie at kernel.org
Thu Apr 9 13:24:44 CEST 2015


On Thu, Apr 09, 2015 at 10:52:38AM +0200, Lars-Peter Clausen wrote:
> If the registration of a debugfs directory fails this is treated as a
> non-fatal error in ASoC and operation continues as normal. This means we
> need to be careful and check if the parent debugfs directory exists if we
> try to register a debugfs file or sub-directory. Otherwise we might end up
> passing NULL for the parent and the file or directory will be registered in
> the top-level debugfs directory.

Hrm, right.  On the one hand just silently ignoring the knock on errors
feels icky on the other hand it's probably better to do something like
this providing the earlier errors got reported (and were actually
earlier, I can see us reordering things and causing further problems
later on).
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 473 bytes
Desc: Digital signature
URL: <http://mailman.alsa-project.org/pipermail/alsa-devel/attachments/20150409/c0e3a90e/attachment.sig>


More information about the Alsa-devel mailing list